-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility of overriding the tailwind.config.js #11763
Conversation
a104803
to
28a1bae
Compare
This is very good, it should be documented! |
I was just searching for the correct file to propose... Probably this is the right place: https://github.com/decidim/decidim/blob/develop/docs/modules/customize/pages/styles.adoc - a new section that says "Tailwind" just after "Webpacker". A good starting point is the instruction from the "Testing" section of this same PR. Can you do that @alecslupu ? |
yes, can be done. |
@andreslucena the few lines have been added a s documentation. Can you have a look and suggest what other information we could add there ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried it locally and it works perfect!
I'd want to make this discoverable, and also to prevent people from changing directly the tailwind.config.js
(that's how I thought this should be done!), so how about adding a header in the template?
diff --git a/decidim-core/lib/decidim/assets/tailwind/tailwind.config.js.erb b/decidim-core/lib/decidim/assets/tailwind/tailwind.config.js.erb
index 6014d388d9..c67b873259 100644
--- a/decidim-core/lib/decidim/assets/tailwind/tailwind.config.js.erb
+++ b/decidim-core/lib/decidim/assets/tailwind/tailwind.config.js.erb
@@ -1,3 +1,10 @@
+// This file is automatically generated.
+// Do not edit this file, it will be overwritten
+//
+// If you want to modify it, follow instructions from
+// https://docs.decidim.org/en/develop/customize/styles
+//
+
const { inherit, current, transparent, white } = require("tailwindcss/colors")
const withOpacity =
@andreslucena this is ready for another round. The change was applied in 0f2b0c6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
Merging as per @andreslucena 's approval. |
* develop: (30 commits) Add `process-content` to erb-lint's deprecated classes (#11762) Add possibility of overriding the tailwind.config.js (#11763) Ask old password when changing email or password (#11737) Add Projects (Budgets) to filtered search (#11740) Fix missing results on Geocoded when search without diacritics (#11761) Add robots.txt instructions (#11693) Add missing activerecord budget locales for search (#11766) Improve design of Admin's Sidebar pages (#11759) Show small static map on admin's meetings index with big screens (#11715) Remove "Manage" button when there's a Sidebar (#11717) Fix admin breadcrumb in Process (#11757) Apply new rubocop rules on erb - Layout/MultilineMethodCallIndentation (#11756) Remove xlarge-* references from admin forms (#11712) Apply new rubocop rules on erb - Argument identation (#11707) Update HERE API autocomplete (#11507) Admin redesign proposal issues (#11668) Redesign: responsive links on cards (#11538) Refactor CI pipelines (#11196) Update postcss and graphql to latest versions (#11733) Fix develop pipeline (#11750) ...
🎩 What? Why?
At the europeean commission we need to add some customization in the font face and other elements, and, for that would be ok to add them in Tailwind . For instance, several things that we need to override :
📌 Related Issues
Link your PR to an issue
Testing
config/tailwind.config.js.erb
following the template