Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing results on Geocoded when search without diacritics #11761

Merged
merged 1 commit into from Oct 16, 2023
Merged

Fix missing results on Geocoded when search without diacritics #11761

merged 1 commit into from Oct 16, 2023

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Oct 15, 2023 •
edited

馃帺 What? Why?

This PR enables the diacritics param on autoComplete.js.

The default of the param is FALSE, yet the argument description states: - Enable to normalize query and data values using String.normalize

馃搶 Related Issues

Testing

  1. Configure geocoding and maps support on your dev instance
  2. Signin as admin and navigate to meetings in a participatory process
  3. Edit the meeting and search for a popular address to validate that geocoding is working (ex Times Square)
  4. Fill in a new address like Stenb盲ckinkatu 24 - See that you have results
  5. Fill in another address like Stenbackinkatu 24 - See there are no results
  6. Apply patch
  7. Fill in a new address like Stenb盲ckinkatu 24 - See that you have results
  8. Fill in another address like Stenbackinkatu 24 - See that you have results ( mind the 盲)

No specs have been implemented

鈾ワ笍 Thank you!

@alecslupu alecslupu added module: core type: fix PRs that implement a fix for a bug labels Oct 15, 2023
@alecslupu alecslupu marked this pull request as ready for review October 16, 2023 07:55
@alecslupu alecslupu requested a review from a team October 16, 2023 07:56
@andreslucena andreslucena changed the title Fix Missing results on Geocoded when search without diacritics Fix missing results on Geocoded when search without diacritics Oct 16, 2023
andreslucena
andreslucena approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@andreslucena andreslucena left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding "Testing" section!

As we've talked, this is really difficult to make specs, so we will not invest time on that. I wouldn't know where to start (something like a webvcr that works with JS and mock the responses from the server? 馃し馃徑 )

Tried it locally and it works as expected. Again, really great Testing 馃憦馃徑 馃憦馃徑

@andreslucena andreslucena merged commit b0e6230 into develop Oct 16, 2023
105 of 106 checks passed
@andreslucena andreslucena deleted the fix/diacritics-in-geocoding branch October 16, 2023 13:31
entantoencuanto added a commit that referenced this pull request Oct 17, 2023
@entantoencuanto
Merge branch 'develop' into feature/redesign-staging
7ceeba2 
* develop: (30 commits)
  Add `process-content` to erb-lint's deprecated classes (#11762)
  Add possibility of overriding the tailwind.config.js (#11763)
  Ask old password when changing email or password (#11737)
  Add Projects (Budgets) to filtered search (#11740)
  Fix missing results on Geocoded when search without diacritics (#11761)
  Add robots.txt instructions (#11693)
  Add missing activerecord budget locales for search (#11766)
  Improve design of Admin's Sidebar pages (#11759)
  Show small static map on admin's meetings index with big screens  (#11715)
  Remove "Manage" button when there's a Sidebar (#11717)
  Fix admin breadcrumb in Process (#11757)
  Apply new rubocop rules on erb - Layout/MultilineMethodCallIndentation (#11756)
  Remove xlarge-* references from admin forms (#11712)
  Apply new rubocop rules on erb - Argument identation (#11707)
  Update HERE API autocomplete (#11507)
  Admin redesign proposal issues (#11668)
  Redesign: responsive links on cards (#11538)
  Refactor CI pipelines (#11196)
  Update postcss and graphql to latest versions (#11733)
  Fix develop pipeline (#11750)
  ...
@andreslucena andreslucena mentioned this pull request Nov 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees
No one assigned
Labels
module: core type: fix PRs that implement a fix for a bug
Projects
Maintainers' backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geocoded fields is unable to search with missing diacritics
2 participants
@alecslupu @andreslucena