Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix admin breadcrumb in Process #11757

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Fix admin breadcrumb in Process #11757

merged 3 commits into from
Oct 16, 2023

Conversation

alecslupu
Copy link
Contributor

@alecslupu alecslupu commented Oct 14, 2023

🎩 What? Why?

This PR tries to fix a wrong link error in the breadcrumb within Participatory space.

📌 Related Issues

Link your PR to an issue

Testing

  1. Visit admin section
  2. Go to a Participatory process
  3. Click on side components ( ex meetings )
  4. Click space name from breadcrumb
  5. Will generate a 500 error ...
  6. Apply patch
  7. repeat 2, 3, 4
  8. See the Participatory Space edit form loads as expected.

📷 Screenshots

image

♥️ Thank you!

@alecslupu alecslupu marked this pull request as ready for review October 15, 2023 08:25
@alecslupu alecslupu added type: fix PRs that implement a fix for a bug contract: redesign Barcelona City Council contract labels Oct 15, 2023
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great finding! Searching for this same problem in other pages, I've seen that we have this same problem in

, so we need to delete that method.

This is accessible by going to the "About this process" page and clicking in the process name in the breadcrumb. This URL: http://localhost:3000/admin/participatory_processes/provision-guess/edit

Can you remove that too? Thanks

@andreslucena andreslucena changed the title Fix admin breadcrumb Fix admin breadcrumb in Process admin Oct 15, 2023
@andreslucena andreslucena changed the title Fix admin breadcrumb in Process admin Fix admin breadcrumb in Process Oct 15, 2023
Copy link
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@andreslucena andreslucena added no-backport Pull Requests that should not be backported module: participatory processes labels Oct 16, 2023
@andreslucena andreslucena merged commit e7d237f into develop Oct 16, 2023
58 checks passed
@andreslucena andreslucena deleted the chore/fix-broken-link branch October 16, 2023 10:13
andreslucena pushed a commit that referenced this pull request Oct 16, 2023
* Fix admin breadcrumb

* Apply review recommendations
entantoencuanto added a commit that referenced this pull request Oct 17, 2023
* develop: (30 commits)
  Add `process-content` to erb-lint's deprecated classes (#11762)
  Add possibility of overriding the tailwind.config.js (#11763)
  Ask old password when changing email or password (#11737)
  Add Projects (Budgets) to filtered search (#11740)
  Fix missing results on Geocoded when search without diacritics (#11761)
  Add robots.txt instructions (#11693)
  Add missing activerecord budget locales for search (#11766)
  Improve design of Admin's Sidebar pages (#11759)
  Show small static map on admin's meetings index with big screens  (#11715)
  Remove "Manage" button when there's a Sidebar (#11717)
  Fix admin breadcrumb in Process (#11757)
  Apply new rubocop rules on erb - Layout/MultilineMethodCallIndentation (#11756)
  Remove xlarge-* references from admin forms (#11712)
  Apply new rubocop rules on erb - Argument identation (#11707)
  Update HERE API autocomplete (#11507)
  Admin redesign proposal issues (#11668)
  Redesign: responsive links on cards (#11538)
  Refactor CI pipelines (#11196)
  Update postcss and graphql to latest versions (#11733)
  Fix develop pipeline (#11750)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract: redesign Barcelona City Council contract module: participatory processes no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants