-
Notifications
You must be signed in to change notification settings - Fork 109
feat: mention keep alive in migration guide #594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughDocuments migration to explicit WebSocket keep-alive via control messages (sent with send_control) and adds two public control-message types for ListenV1 and AgentV1 in deepgram.extensions.types.sockets; updates migration guide and breaking changes accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant Conn as ListenV1 / AgentV1 Connection
participant WS as WebSocket Server
Note over Client,Conn: Client controls keep-alive explicitly via control messages
Client->>Conn: open_connection(headers: additional_headers / extra_headers)
Conn->>WS: WebSocket handshake
WS-->>Conn: connection established
loop periodic keep-alive
Client->>Conn: send_control(KeepAlive: ListenV1ControlMessage / AgentV1ControlMessage)
Conn->>WS: ControlMessage: KeepAlive
WS-->>Conn: ack / keep-alive response (optional)
end
Client->>Conn: close()
Conn->>WS: close frame
WS-->>Conn: closed
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/Migrating-v3-to-v5.md(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test (3.9)
Summary by CodeRabbit