-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump actions/checkout from 3 to 4 #349
Conversation
Looking through the failures are reasons behind them: The v4 action switches from node.js 16 (EOL a month ago) to 20, which n newer glibc/c++ that is missing on CentOS 7 and Ubuntu 18.04. The latter has gone EOL a few months ago - Ubuntu are providing extra (read $$$$$) HWE support. The former is still supported until mid 2024, although with the overall CentOS future looking fuzzy I'm inclined to drop it earlier than later. Unless we have someone to semi-actively maintain it of course. So I'm inclined to simply drop the two - CentOS 7 and Ubuntu 18.04 - and merge this. @scaronni any preferences, suggestions? @fishilico you've added the initial CI (huge thanks for which). Did you add CentOS with a particular use-case in mind? If so would you be interested in maintaining it or any other version? |
I'm still packaging DKMS for CentOS 7 in EPEL until the EOL date (2024.06), but I think you can remove it anyway from the tests. |
Ouch - are you still packaging the latest or you're using a fixed older version? AFAICT there is nothing security-wise in the diff log in the action, so there's no need to actually update it. Edit: Considering the EOL numbers - Stream 8 is EOL in April 2024, while 7 is July 2024 - I'm inclined that we can leave this PR open until then ;-) |
I'm updating to the latest on all supported EPEL/Fedora releases. The DKMS package is then picked up by Nvidia and AMD for bundling in their RPM based installers (graphic card drivers from AMD, DGX packages from Nvidia, etc.). |
Plus we use them at work :) |
Thanks - flipping to draft. This can sit until some point next year (edit: or later) IMHO. I really don't want to make your life harder than needed. Especially since there is no obvious benefit of using the newer actions. |
c2e1f36
to
f67b4dc
Compare
f67b4dc
to
e41b640
Compare
@dependabot rebase |
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
e41b640
to
7a8f36c
Compare
Anything requiring old |
Bumps actions/checkout from 3 to 4.
Release notes
Sourced from actions/checkout's releases.
... (truncated)
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
8ade135
Prepare 4.1.0 release (#1496)c533a0a
Add support for partial checkout filters (#1396)72f2cec
Update README.md for V4 (#1452)3df4ab1
Release 4.0.0 (#1447)8b5e8b7
Support fetching without the --progress option (#1067)97a652b
Update default runtime to node20 (#1436)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)