Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deno too aggressively ignores folders named vendor #22833

Closed
dsherret opened this issue Mar 10, 2024 · 0 comments · Fixed by #23100
Closed

Deno too aggressively ignores folders named vendor #22833

dsherret opened this issue Mar 10, 2024 · 0 comments · Fixed by #23100
Labels
suggestion suggestions for new features (yet to be agreed)

Comments

@dsherret
Copy link
Member 

          This `ignore_vendor_folder` seems too broad and we should probably leave this up to users to ignore if they want to. (it should be more targeted like this vendor_folder option I just added). Maybe something to do in 1.42?

Originally posted by @dsherret in #22830 (comment)
@dsherret dsherret added the suggestion suggestions for new features (yet to be agreed) label Mar 10, 2024
@dsherret dsherret added this to the 1.42 milestone Mar 10, 2024
@dsherret dsherret changed the title Deno too aggressively ignores vendor folder Deno too aggressively ignores folders named vendor Mar 10, 2024
@dsherret dsherret mentioned this issue Mar 27, 2024
Merged
dsherret added a commit that referenced this issue Mar 27, 2024
@dsherret
fix: less aggressive vendor folder ignoring (#23100)
68fecc6 
This is slightly breaking as some users want the `vendor` folder
excluded and may not have that specified in their deno.json.

Closes #22833
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: less aggressive vendor folder ignoring dsherret/deno
1 participant
@dsherret