chore: update actions to use google-github-actions/setup-gcloud@v1
#16674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Nov 20, 2022
|
Your question prompted me to double-check. Now, |
|
Note to self: if landed, apply these changes to #14448 |
bartlomieju
reviewed
Jan 11, 2023
| startsWith(github.ref, 'refs/tags/')) | ||
| uses: google-github-actions/auth@v1 | ||
| with: | ||
| project_id: denoland |
There was a problem hiding this comment.
Where did you take that project_id from @iuioiua?
|
Thanks, I included your changes in #17358, gonna close this one. |
bartlomieju
added a commit
that referenced
this pull request
Jan 12, 2023
…de (#17358) This commit rolls up following PRs into a single one: - #16672 - #16674 - #16972 Generation script was updated to take into account these changes. Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com> Co-authored-by: Geert-Jan Zwiers <geertjanzwiers@protonmail.com> Co-authored-by: David Sherret <dsherret@gmail.com>
dsherret
added a commit
that referenced
this pull request
Jan 13, 2023
…de (#17358) This commit rolls up following PRs into a single one: - #16672 - #16674 - #16972 Generation script was updated to take into account these changes. Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com> Co-authored-by: Geert-Jan Zwiers <geertjanzwiers@protonmail.com> Co-authored-by: David Sherret <dsherret@gmail.com>
dsherret
added a commit
that referenced
this pull request
Jan 13, 2023
…de (#17358) This commit rolls up following PRs into a single one: - #16672 - #16674 - #16972 Generation script was updated to take into account these changes. Co-authored-by: Asher Gomez <ashersaupingomez@gmail.com> Co-authored-by: Geert-Jan Zwiers <geertjanzwiers@protonmail.com> Co-authored-by: David Sherret <dsherret@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades
google-github-actions/setup-gcloud@v0to the recommendedgoogle-github-actions/setup-gcloud@v1within thebuild,publish-canaryandupdate-dl-versionjobs.