feat(cron) implement Deno.cron() #21019
Conversation
| [[package]] | ||
| name = "saffron" | ||
| version = "0.1.0" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "03fb9a628596fc7590eb7edbf7b0613287be78df107f5f97b118aad59fb2eea9" | ||
| dependencies = [ | ||
| "chrono", | ||
| "nom 5.1.3", | ||
| ] |
There was a problem hiding this comment.
Is saffron maintained anymore? cloudflare/saffron#20
Anyways, we should ask saffron to upgrade to nom 7.1
There was a problem hiding this comment.
I got confirmation that Cloudflare is happy to merge PRs, as it is still in use at CF.
There was a problem hiding this comment.
@littledivy can we do this after this PR is landed?
There was a problem hiding this comment.
Working on an alternative to saffron that might be of interest - with second granularity and support for timezoned DateTimes. Also nicknames for @hourly. Extended syntax like L for last occurrence of weekday in month. Standards-compliant weekday entry (1 is monday, in saffron 0 seem to be monday). Early stuff, started yesterday, and (disclaimer) my first Rust project ever, but starting to look like something - https://crates.io/crates/croner/0.0.3 https://github.com/hexagon/croner-rust
There was a problem hiding this comment.
@igorzi ready to run (or to be roasted 😉):
https://github.com/Hexagon/croner-rust/releases/tag/v1.0.0
https://github.com/Hexagon/croner-rust#why-croner-instead-of-cron-or-saffron
cli/tests/unit/cron_test.ts
Outdated
| try { | ||
| assertThrows( | ||
| () => Deno.cron("abc", "*/20 * * * *", () => {}), | ||
| "Invalid cron name", |
There was a problem hiding this comment.
Maybe use a different error message, Invalid cron name for a duplicate name is confusing - e.g. a dependency of dependency registers a cron and suddenly you get this error in your own code
There was a problem hiding this comment.
Oh, this test is wrong. 2nd arg to assertThrows should be the exception type. I'll fix the tests and make sure that it's checking for the correct error message.
This PR adds unstable
Deno.cronAPI to trigger execution of cron jobs.options.backoffSchedule.