-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coverage): add html reporter #21495
Conversation
4a46ca5
to
45b76bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I found a couple issues, that I think should be addressed before we land it.
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com> Signed-off-by: Yoshiya Hinosawa <stibium121@gmail.com>
Looks good to me, but the Windows CI keep failing :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Windows path issues are resolved. Landing |
This PR adds html coverage reporter to
deno coverage
command.If you add
--html
option, then the command generates html coverage report under the given coverage directory.The page has 2 patterns: index page and source code page. They look like the below:
part of #21325