Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(coverage): add html reporter #21495

Merged
merged 10 commits into from
Dec 8, 2023
Merged

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Dec 7, 2023

This PR adds html coverage reporter to deno coverage command.

If you add --html option, then the command generates html coverage report under the given coverage directory.

The page has 2 patterns: index page and source code page. They look like the below:

Screenshot 2023-12-08 at 2 04 51 Screenshot 2023-12-08 at 2 05 54

part of #21325

@kt3k kt3k requested a review from bartlomieju December 7, 2023 17:07
@kt3k kt3k force-pushed the html-coverage-reporter branch from 4a46ca5 to 45b76bc Compare December 7, 2023 17:13
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I found a couple issues, that I think should be addressed before we land it.

cli/args/flags.rs Outdated Show resolved Hide resolved
cli/args/flags.rs Outdated Show resolved Hide resolved
cli/tests/integration/coverage_tests.rs Show resolved Hide resolved
cli/tools/coverage/mod.rs Show resolved Hide resolved
cli/tools/coverage/mod.rs Show resolved Hide resolved
cli/tools/coverage/mod.rs Outdated Show resolved Hide resolved
kt3k and others added 5 commits December 8, 2023 09:29
Co-authored-by: Bartek Iwańczuk <biwanczuk@gmail.com>
Signed-off-by: Yoshiya Hinosawa <stibium121@gmail.com>
@bartlomieju
Copy link
Member

Looks good to me, but the Windows CI keep failing :(

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k
Copy link
Member Author

kt3k commented Dec 8, 2023

Windows path issues are resolved. Landing

@kt3k kt3k merged commit d68d1e2 into denoland:main Dec 8, 2023
14 checks passed
@kt3k kt3k deleted the html-coverage-reporter branch December 8, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants