Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(node): ensure cjs wrapper module has deterministic output #24248

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Jun 18, 2024

As reported by @igorzi

We need to ensure the cjs wrapper module has deterministic output so we don't update the code cache each run.

@dsherret dsherret changed the title perf(node): ensure esm cjs wrapper module has deterministic output perf(node): ensure cjs wrapper module has deterministic output Jun 18, 2024
@dsherret dsherret marked this pull request as ready for review June 18, 2024 18:49
@dsherret dsherret requested a review from igorzi June 18, 2024 18:49
@dsherret dsherret merged commit cba212b into denoland:main Jun 18, 2024
17 checks passed
@dsherret dsherret deleted the perf_code_cache_cjs_wrapper branch June 18, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants