BREAKING: `DENO_FUTURE=1` by default, or welcome to Deno 2.0 #25213

bartlomieju · 2024-08-26T14:19:30Z

This commit effectively turns Deno into Deno 2.0.

This is done by forcing DENO_FUTURE=1 env var, that was available in
the past few months to try Deno 2 changes.

This commit contains several breaking changes scheduled for Deno 2:

all deprecated JavaScript APIs are not available any more, mostly Deno.* APIs
window global is removed
FFI, WebGPU and FS APIs are now stable and don't require --unstable-* flags
import assertions are no longer supported
"bring your own node modules" is enabled by default

This is the first commit in a series that are scheduled before the Deno 2 release.

Follow up work is tracked in #25241.

iuioiua

I wonder whether we really require the ability to have DENO_FUTURE=0. Either way, LGTM!

iuioiua

Tests will need to be updated

iuioiua · 2024-08-27T04:59:13Z

We're running into this issue quite a bit:

error: Could not resolve "@denotest/esm-basic", but found it in a package.json. Deno expects the node_modules/ directory to be up to date. Did you forget to run `npm install`?

How should we approach folders that have a package.json but don't have the node_modules folder? Should we just use --node-modules-dir=false?

Needed for #25213. With Deno 2, we should suggest using `deno install` instead of `npm install`.

…fault

This is still flaky and won't be needed anyway once #25213 lands.

Needed for #25213. With Deno 2, we should suggest using `deno install` instead of `npm install`.

Co-Authored-By: Nayeem Rahman <nayeemrmn99@gmail.com>

nathanwhit

LGTM, cleanup will be fun 😅

dsherret

LGTM!

dsherret · 2024-08-30T14:40:19Z

tests/integration/lsp_tests.rs

@@ -14240,7 +14247,7 @@ fn lsp_deno_json_workspace_node_modules_dir() {
    "project1/deno.json",
    json!({
      "workspace": ["project2"],
-      "nodeModulesDir": true,
+      "nodeModules": "local-auto",


I think we should change this to "nodeModules": "auto". This is too much to type.

Out of date

bartlomieju added 2 commits August 26, 2024 16:19

feat: Make DENO_FUTURE the default

91e814a

Merge branch 'main' into make_deno_future_default

76f7b11

iuioiua approved these changes Aug 26, 2024

View reviewed changes

iuioiua previously requested changes Aug 26, 2024

View reviewed changes

iuioiua and others added 5 commits August 27, 2024 09:03

fixes

6eb1bb3

Merge branch 'main' into make_deno_future_default

d938b45

make DENO_FUTURE equal to true

f8d95ff

fixes

adb379d

work

89d9054

iuioiua changed the title ~~feat: Make DENO_FUTURE the default~~ feat: make DENO_FUTURE=1 the default Aug 27, 2024

bartlomieju added 2 commits August 28, 2024 00:40

Merge branch 'main' into make_deno_future_default

7e167a7

make unstable tests work

382c846

bartlomieju mentioned this pull request Aug 27, 2024

Cleanup after DENO_FUTURE is enabled by default #25241

Open

40 tasks

bartlomieju added 4 commits August 28, 2024 01:41

add support for ignoring spec tests, ignore some for lockfile

a399443

fix bench::package_json

c7bcd09

cache and import assertions

7fbc0de

Merge branch 'main' into make_deno_future_default

c99e1dd

bartlomieju mentioned this pull request Aug 28, 2024

fix: replace npm install hint with deno install hint #25244

Merged

Merge branch 'main' into make_deno_future_default

ecf0057

bartlomieju added a commit that referenced this pull request Aug 28, 2024

fix: replace npm install hint with deno install hint (#25244)

3dba985

Needed for #25213. With Deno 2, we should suggest using `deno install` instead of `npm install`.

bartlomieju added 2 commits August 28, 2024 14:29

Merge remote-tracking branch 'upstream/main' into make_deno_future_de…

0c7db38

…fault

Merge branch 'main' into make_deno_future_default

2fb57f5

bartlomieju mentioned this pull request Aug 28, 2024

test: Don't run unit tests with and without DENO_FUTURE=1 #25273

Merged

bartlomieju added a commit that referenced this pull request Aug 28, 2024

test: Don't run unit tests with and without DENO_FUTURE=1 (#25273)

231bdc0

This is still flaky and won't be needed anyway once #25213 lands.

bartlomieju added 5 commits August 28, 2024 23:36

Merge branch 'main' into make_deno_future_default

4e54620

fix flags test

9a6cd54

ignore serveral specs tests

52308d2

lifecycle scripts tests

96c5dc7

ignore two workspace tests

0de650e

Merge branch 'main' into make_deno_future_default

f1740db

lucacasonato pushed a commit that referenced this pull request Aug 29, 2024

fix: replace npm install hint with deno install hint (#25244)

e3c4651

Needed for #25213. With Deno 2, we should suggest using `deno install` instead of `npm install`.

bartlomieju and others added 9 commits August 29, 2024 16:15

ignore lsp tests

980ba29

Merge branch 'main' into make_deno_future_default

1e33c7b

Try to polyfill window in WPT

690fdae

fmt

6b2c67e

fix LSP tests

3a9254c

Co-Authored-By: Nayeem Rahman <nayeemrmn99@gmail.com>

try to fix wpt again

c98ba28

disable some WPT

673eaa3

Merge branch 'main' into make_deno_future_default

c093402

fix flags test

ecf1abc

nathanwhit approved these changes Aug 30, 2024

View reviewed changes

bartlomieju changed the title ~~feat: make DENO_FUTURE=1 the default~~ BREAKING: DENO_FUTURE=1 by default, or welcome Deno 2.0 Aug 30, 2024

bartlomieju changed the title ~~BREAKING: DENO_FUTURE=1 by default, or welcome Deno 2.0~~ BREAKING: DENO_FUTURE=1 by default, or welcome to Deno 2.0 Aug 30, 2024

nathanwhit and others added 6 commits August 29, 2024 18:03

Fix conditions for byonm + node_modules dir

b9ea4a8

run, compile, task, vendor

9681884

npm tests

ff60513

fix up specs tests

c4169b1

lsp tests

137b161

Merge branch 'main' into make_deno_future_default

7093ccd

dsherret approved these changes Aug 30, 2024

View reviewed changes

dsherret merged commit b1c6142 into denoland:main Aug 30, 2024
17 checks passed

bartlomieju deleted the make_deno_future_default branch August 30, 2024 19:01

iuioiua mentioned this pull request Sep 1, 2024

tracking: Deno 2 subcommand, flag and symbol removals #22079

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BREAKING: `DENO_FUTURE=1` by default, or welcome to Deno 2.0 #25213

BREAKING: `DENO_FUTURE=1` by default, or welcome to Deno 2.0 #25213

bartlomieju commented Aug 26, 2024 •

edited

Loading

iuioiua left a comment

iuioiua left a comment

iuioiua commented Aug 27, 2024 •

edited

Loading

nathanwhit left a comment

dsherret left a comment

dsherret Aug 30, 2024

BREAKING: DENO_FUTURE=1 by default, or welcome to Deno 2.0 #25213

BREAKING: DENO_FUTURE=1 by default, or welcome to Deno 2.0 #25213

Conversation

bartlomieju commented Aug 26, 2024 • edited Loading

iuioiua left a comment

Choose a reason for hiding this comment

iuioiua left a comment

Choose a reason for hiding this comment

iuioiua commented Aug 27, 2024 • edited Loading

nathanwhit left a comment

Choose a reason for hiding this comment

dsherret left a comment

Choose a reason for hiding this comment

dsherret Aug 30, 2024

Choose a reason for hiding this comment

BREAKING: `DENO_FUTURE=1` by default, or welcome to Deno 2.0 #25213

BREAKING: `DENO_FUTURE=1` by default, or welcome to Deno 2.0 #25213

bartlomieju commented Aug 26, 2024 •

edited

Loading

iuioiua commented Aug 27, 2024 •

edited

Loading