feat: Wasm module support #26668
Merged
feat: Wasm module support #26668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
force-pushed
the
wasm_support
branch
from
66d2f67 to
76412c1
Compare
bartlomieju
approved these changes
Nov 19, 2024
| @@ -78,7 +78,7 @@ pub fn validate_import_attributes_callback( | |||
| for (key, value) in attributes { | |||
| let msg = if key != "type" { | |||
| Some(format!("\"{key}\" attribute is not supported.")) | |||
| } else if value != "json" { | |||
| } else if value != "json" && value != "$$deno-core-internal-wasm-module" { | |||
There was a problem hiding this comment.
I probably should have exported that string in deno_core or handled the validation there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Wasm modules.
Note this implements the standard where the default export is the instance (not the module). The module will come later with source phase imports.
Closes #2552