-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli/rt/performance): Check for object props in startOrMeasureOptions before throwing #7884
fix(cli/rt/performance): Check for object props in startOrMeasureOptions before throwing #7884
Conversation
Cool. For the tests, they should get added here: https://github.com/denoland/deno/blob/master/cli/tests/unit/performance_test.ts |
PTAL @kitsonk Also:
I think this is unrelated to my commits, but if I did something wrong, please let me know how to avoid it in the future.
|
Yeah, something is wrong with CI right now... I'm waiting for other to come online because it is currently beyond my ability to know why it is broken. |
@kitsonk Is the CLI fixed yet? How can the checks be re-run so this PR is ready for review? I don't see any UI for that action... |
@jsejcksn |
I thought there was a way for collaborators to manually re-run checks without another commit having to be pushed. I remember seeing it in the GitHub docs a while back, but I can't find it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #7876
Still needs tests; not sure where they belong.
/cc @kitsonk