Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli/rt/performance): Check for object props in startOrMeasureOptions before throwing #7884

Merged
merged 8 commits into from
Oct 20, 2020
Merged

fix(cli/rt/performance): Check for object props in startOrMeasureOptions before throwing #7884

merged 8 commits into from
Oct 20, 2020

Conversation

jsejcksn
Copy link
Contributor

@jsejcksn jsejcksn commented Oct 8, 2020

Fixes #7876

Still needs tests; not sure where they belong.
/cc @kitsonk

@kitsonk
Copy link
Contributor

kitsonk commented Oct 8, 2020

Cool. For the tests, they should get added here: https://github.com/denoland/deno/blob/master/cli/tests/unit/performance_test.ts

@jsejcksn jsejcksn marked this pull request as ready for review October 9, 2020 04:25
@jsejcksn
Copy link
Contributor Author

jsejcksn commented Oct 9, 2020

PTAL @kitsonk

Also:

  1. The ubuntu ci build failed because of something related to rusty v8:

error: could not find native static library rusty_v8, perhaps an -L flag is missing?

I think this is unrelated to my commits, but if I did something wrong, please let me know how to avoid it in the future.

  1. In the tests, is assert used with === instead of assertEquals because assertEquals does not use object equality?

@kitsonk
Copy link
Contributor

kitsonk commented Oct 9, 2020

Yeah, something is wrong with CI right now... I'm waiting for other to come online because it is currently beyond my ability to know why it is broken.

@jsejcksn
Copy link
Contributor Author

@kitsonk Is the CLI fixed yet? How can the checks be re-run so this PR is ready for review? I don't see any UI for that action...

@kitsonk
Copy link
Contributor

kitsonk commented Oct 13, 2020

@jsejcksn git commit --allow-empty -m "bump" & git push

@jsejcksn
Copy link
Contributor Author

git commit --allow-empty -m "bump" & git push

I thought there was a way for collaborators to manually re-run checks without another commit having to be pushed. I remember seeing it in the GitHub docs a while back, but I can't find it now.

Copy link
Contributor

@kitsonk kitsonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitsonk kitsonk merged commit 992c2a4 into denoland:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

performance.measure throws when measuring from navigation by providing undefined startMark
4 participants