TICtxtWrd-common: Test Improvement, Context Wording, for ecosystem common. #9780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…9768) Co-authored-by: “Thavachelvam <“thavaahariharangit@git.com”>
Pin remaining GitHub actions to SHA hash
…safe_load (#9759) * Fixes Alias parsing was not enabled issue while loading Psych Lib in safe_load
…ver-true-type True type `Dependabot::NpmAndYarn::UpdateChecker::VersionResolver`
* parge the multiple json object response and handle both default and sparse registry responses in available_versions
jurre
reviewed
May 21, 2024
common/spec/dependabot/metadata_finders/base/changelog_finder_spec.rb
Outdated
Show resolved
Hide resolved
added 4 commits
May 21, 2024 10:52
…t/dependabot-core into harry/TICtxtWrd-common
github-actions
bot
added
L: rust:cargo
* Enable RSpec/EmptyLineAfterExample * Enable RSpec/EmptyLineAfterExampleGroup * Enable RSpec/EmptyLineAfterFinalLet * Enable RSpec/EmptyLineAfterHook * Enable RSpec/EmptyLineAfterSubject
…w comments of #9758 addressed here. (#9782) * TICtxtWrd-bundler: Test Improvement, Context Wording, ecosystem bundler. * TICtxtWrd-bundler: Test Improvement, Context Wording, ecosystem bundler. * TICtxtWrd-bundler: Test Improvement, Context Wording, ecosystem bundler. * TICtxtWrd-bundler: Test Improvement, Context Wording, ecosystem bundler. * TICtxtWrd-bundler: Rebasing main. * TICtxtWrd-bundler: Test Improvement, Context Wording, ecosystem bundler. * TICtxtWrd-bundler: Fixing with code spell error. * TICtxtWrd-bundler:Fixing the codespell error. * TICtxtWrd-bundler: Fixing the lint errors. --------- Co-authored-by: “Thavachelvam <“thavaahariharangit@git.com”>
…t/dependabot-core into harry/TICtxtWrd-common
github-actions
bot
added
L: php:composer
…9070) * Added support for .tool-versions file in Gemfile for Ruby projects * Filter out all support files from evaled_gemfiles() without listing each pattern separately * Updated RSpec context description to match linter requirement (should start with when/with/without)
|
Looks like some merge conflicts in this PR, I see a bunch of unrelated commits etc, could you clean that up please? |
…dler::LazySpecification issue (#9807) * monkey patch Bundler::SpecSet#materialize_for_all_platforms
GCC 14 was release on 7th May[^1]. It introduced a new warning `-Wno-calloc-transposed-args`[^2] designd to raise a warning when the arguments to `calloc` were given in the wrong order.
Unfortunately, `prism` version `0.24.0` made this mistake. Attempting to `bundle install` Dependabot gives the error:
<details>
<summary>Error details</summary>
```
src/diagnostic.c: In function ‘pm_diagnostic_list_append’:
src/diagnostic.c:328:69: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
328 | pm_diagnostic_t *diagnostic = (pm_diagnostic_t *) calloc(sizeof(pm_diagnostic_t), 1);
| ^~~~~~~~~~~~~~~
src/diagnostic.c:328:69: note: earlier argument should specify number of elements, later size of each element
src/diagnostic.c: In function ‘pm_diagnostic_list_append_format’:
src/diagnostic.c:359:69: error: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Werror=calloc-transposed-args]
359 | pm_diagnostic_t *diagnostic = (pm_diagnostic_t *) calloc(sizeof(pm_diagnostic_t), 1);
| ^~~~~~~~~~~~~~~
src/diagnostic.c:359:69: note: earlier argument should specify number of elements, later size of each element
cc1: all warnings being treated as errors
```
</details>
The issue was logged upstream in ruby/prism#2645, fixed in ruby/prism#2648, and released in https://github.com/ruby/prism/releases/tag/v0.25.0.
This change upgrades `prism`, by way of upgrading `rbi`, and resolves the compile error.
[^1]: https://gcc.gnu.org/gcc-14/
[^2]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wno-calloc-transposed-args
By default the top-level `GITHUB_TOKEN` has all permissions[^1]. This change removes all permissions by default, as recommended by the GitHub Actions security hardening guide[^2]. This change is a low risk test. I plan to modify all other workflows if this works okay. [^1]: https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token [^2]: https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#restricting-permissions-for-tokens
When a version range with a '<' character is found, the range is updated to the (latest version + 1). However for a range using "<=" this is invalid. Add a special case for a range using Less Than Equal which is updated to simply the latest version. Co-authored-by: AbdulFattaah Popoola <abdulapopoola@github.com>
|
#9856 is deployed and merged |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Improvement, Context Wording, for ecosystem common.
Writing a sensible context, for test.