Initial Python sdk code #1

guyp-descope · 2022-05-19T20:32:39Z

TODOs:

Adjust some exceptions
Add Docs (inline, Readme and Notion)
Add the Code coverage badge (values are already calculated and stand on 93%)
Remove some values used for the testing

aviadl · 2022-05-20T06:47:35Z

Didn't you review this with @dorsha ?

dorsha · 2022-05-20T06:55:03Z

Didn't you review this with @dorsha ?

Not everything, there are still some leftovers

dorsha

Very nice!

See comments
What is the empty pyproject.toml file?
Don't forget to add the gitleaks
Let me know once other stuff are ready so I will review again
What is the part which is not covered in the coverage?

.github/workflows/ci.yaml

README.md

descope/common.py

setup.cfg

setup.py

descope/auth.py

dorsha · 2022-05-21T06:34:21Z

I see the coverage is only for the errors, if possible I would mock some of them to check the error behavior, since it is important in term of the sdk.

aviadl

Who is writing all the py docs ?
What did we do with the go docs?

Need to sit with @jeff-descope and make prepare this process

descope/auth.py

samples/sample_app.py

samples/web_sample_app.py

descope/auth.py

dorsha · 2022-05-23T18:21:46Z

Can we change it to be updated only in a single comment?

guyp-descope · 2022-05-23T20:19:45Z

Can we change it to be updated only in a single comment?

I tried to do so and added the flag we talked about but looks like its didnt help..
I think Ill replace the badge component..

dorsha · 2022-05-23T20:36:41Z

Yes, maybe better to replace with this, like we did in our services and in the console-app:
https://github.com/descope/console-app/blob/main/.github/workflows/ci.yml#L55

https://github.com/devmasx/coverage-check-action

…t request) 3. add more UT

…nly on pull request event

github-actions · 2022-05-25T12:45:56Z

Coverage Report

File	Stmts	Miss	Cover
TOTAL	254	0	100%

Tests	Skipped	Failures	Errors	Time
19	0 💤	0 ❌	0 🔥	0.748s ⏱️

…ve samples 4. started to add documentation (including README.md file)

samples/web_sample_app.py

descope/auth.py

README.md

samples/sample_app.py

dorsha

Nice!

.github/workflows/ci_pr.yaml

README.md

setup.cfg

setup.py

setup.cfg

samples/sample_app.py

descope/auth.py

README.md

descope/auth.py

liccheck.ini

…he user. 2. add logic for all the refresh token 3. add more unittests 4. adjust the samples apps to the new logic and return values

dorsha

Nice

README.md

descope/auth.py

samples/decorators/flask_decorators.py

dorsha · 2022-05-30T10:09:40Z

So let's merge this one, and have the leftovers in a different PR

Guy Pilosof and others added 13 commits May 19, 2022 13:31

initial python sdk code

7699205

fix github isort action

b83a0da

fix github isort action wip2

902e9fe

fix github isort action wip3

043ffbb

fix github unittest action wip4

78e5a94

fix github unittest action wip5

03941d0

fix github unittest action wip6

9afaf77

fix github unittest action wip7

757c24d

add github python code coverage action wip8

2b9f5b3

add github python code coverage action wip9

252ca25

add github python code coverage action wip10

30b1c74

add github python code coverage action wip11

3d07f9a

fixes some bugs and added functionality of fetching public key

1a50cee

guyp-descope requested review from dorsha, meirwah, aviadl and Bars92 May 19, 2022 20:32

guyp-descope self-assigned this May 19, 2022

dorsha reviewed May 21, 2022

View reviewed changes

aviadl reviewed May 21, 2022

View reviewed changes

guyp-descope added 7 commits May 22, 2022 13:16

Add unittest for better coverage

18efbc8

remove the pyproject.toml file (not in used)

c9811bc

add gitleaks Action

bdf01c4

add gitleaks to workflow, some PR fixes

3f45417

add github checkout action

5946440

fix github action

2d22181

fix github action

0ce81e1

add new package to requirements file

d377caf

meirwah reviewed May 23, 2022

View reviewed changes

descope/auth.py Show resolved Hide resolved

change badge namedlogo

6914192

guyp-descope added 9 commits May 24, 2022 10:41

change coverage badge

2ae8bf5

change coverage badge

8089b04

revert to the latest coverage badge

11f02a4

1. Add support for refresh token 2. Fix decorator (to support pre-pos…

6da0ad6

…t request) 3. add more UT

fix UT

d6d3409

add license check for pre-commit and part of the ci workflow

cf65450

fix license checks

08e56e7

fix license checks 2

344022f

seperate the coverage steps to run on a different workflow that run o…

1e8a68d

…nly on pull request event

1. fixed few bugs 2. added flask decorator functions example 3. impro…

63a161e

…ve samples 4. started to add documentation (including README.md file)

Bars92 reviewed May 26, 2022

View reviewed changes

samples/web_sample_app.py Show resolved Hide resolved

samples/web_sample_app.py Outdated Show resolved Hide resolved

descope/auth.py Outdated Show resolved Hide resolved

README.md Show resolved Hide resolved

samples/sample_app.py Show resolved Hide resolved

dorsha reviewed May 26, 2022

View reviewed changes

aviadl reviewed May 26, 2022

View reviewed changes

README.md Outdated Show resolved Hide resolved

descope/auth.py Show resolved Hide resolved

liccheck.ini Show resolved Hide resolved

guyp-descope added 3 commits May 27, 2022 02:39

fix pr comments

b2b1474

fix some more pr comments

4ae2458

1. change the api so the claims (jwt payload) will be available for t…

e32b425

…he user. 2. add logic for all the refresh token 3. add more unittests 4. adjust the samples apps to the new logic and return values

dorsha reviewed May 30, 2022

View reviewed changes

README.md Show resolved Hide resolved

descope/auth.py Outdated Show resolved Hide resolved

descope/auth.py Show resolved Hide resolved

samples/decorators/flask_decorators.py Show resolved Hide resolved

set alg as const

cfb24c8

dorsha approved these changes May 30, 2022

View reviewed changes

dorsha marked this pull request as ready for review May 30, 2022 08:17

guyp-descope merged commit a76d544 into main May 31, 2022

guyp-descope deleted the draft branch May 31, 2022 07:20

Initial Python sdk code #1

Initial Python sdk code #1

Uh oh!

Conversation

guyp-descope commented May 19, 2022

Uh oh!

aviadl commented May 20, 2022

Uh oh!

dorsha commented May 20, 2022

Uh oh!

dorsha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dorsha commented May 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aviadl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dorsha commented May 23, 2022

Uh oh!

guyp-descope commented May 23, 2022

Uh oh!

dorsha commented May 23, 2022

Uh oh!

github-actions bot commented May 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dorsha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dorsha left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dorsha commented May 30, 2022

Uh oh!

Uh oh!

dorsha commented May 21, 2022 •

edited

Loading

github-actions bot commented May 25, 2022 •

edited

Loading