Skip to content

Sdk take 2 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 19, 2022
Merged

Sdk take 2 #20

merged 13 commits into from
Jul 19, 2022

Conversation

guyp-descope
Copy link
Contributor

  1. Remove User object (it will be only dict from now (this is the pythonic way))
  2. Adjust all code to work with the new jwt on body and cookie and return jwt_response after verification

@guyp-descope guyp-descope requested a review from aviadl July 17, 2022 21:26
@github-actions
Copy link

github-actions bot commented Jul 17, 2022 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
descope
   auth.py289499%354–361
TOTAL324499% 

Tests Skipped Failures Errors Time
24 0 💤 0 ❌ 0 🔥 1.608s ⏱️

guyp-descope
guyp-descope commented Jul 17, 2022
View reviewed changes
guyp-descope
guyp-descope commented Jul 17, 2022
View reviewed changes
aviadl
aviadl reviewed Jul 18, 2022
View reviewed changes
@guyp-descope guyp-descope requested a review from aviadl July 18, 2022 12:12
asafshen
asafshen reviewed Jul 18, 2022
View reviewed changes
aviadl
aviadl reviewed Jul 19, 2022
View reviewed changes
Copy link
Member

@aviadl aviadl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment

@guyp-descope guyp-descope requested a review from aviadl July 19, 2022 07:45
aviadl
aviadl previously approved these changes Jul 19, 2022
View reviewed changes
@guyp-descope guyp-descope requested a review from aviadl July 19, 2022 07:59
aviadl
aviadl previously approved these changes Jul 19, 2022
View reviewed changes
@guyp-descope guyp-descope requested a review from aviadl July 19, 2022 08:33
@guyp-descope guyp-descope merged commit 66ec163 into main Jul 19, 2022
@guyp-descope guyp-descope deleted the sdk-take-2 branch July 19, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafshen asafshen asafshen left review comments

@aviadl aviadl aviadl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guyp-descope @asafshen @aviadl