Skip to content

Fix sample app, to place data on cookie propely #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Fix sample app, to place data on cookie propely #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions samples/otp_web_sample_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,20 @@
descope_client = DescopeClient(PROJECT_ID, skip_verify=True)


def set_cookie_on_response(response: Response, data):
cookie_domain = data.get("cookieDomain", "")
def set_cookie_on_response(response: Response, cookieAttributes, data):
cookie_domain = cookieAttributes.get("cookieDomain", "")
if cookie_domain == "":
cookie_domain = None

current_time = datetime.datetime.now()
expire_time = current_time + datetime.timedelta(days=30)

return response.set_cookie(
key=data.get("cookieName", ""),
key=data.get("drn", ""),
value=data.get("jwt", ""),
max_age=data.get("cookieMaxAge", int(expire_time.timestamp())),
expires=data.get("cookieExpiration", expire_time),
path=data.get("cookiePath", ""),
max_age=cookieAttributes.get("cookieMaxAge", int(expire_time.timestamp())),
expires=cookieAttributes.get("cookieExpiration", expire_time),
path=cookieAttributes.get("cookiePath", ""),
domain=cookie_domain,
secure=False, # True
httponly=True,
Expand Down Expand Up @@ -116,14 +116,14 @@ def verify():
jwt_response = descope_client.otp.verify_code(DeliveryMethod.EMAIL, email, code)
except AuthException:
return Response("Unauthorized", 401)

data = jwt_response["jwts"]
response = Response(
f"This is Verify code API handling, info example: {json.dumps(jwt_response)}",
200,
)
for _, cookieData in data.items():
set_cookie_on_response(response, cookieData)

set_cookie_on_response(response, data, data.get("DS"))
set_cookie_on_response(response, data, data.get("DSR"))

return response

Expand All @@ -142,8 +142,10 @@ def private():
response = Response(
"This is a private API and you must be authenticated to see this", 200
)
for _, cookieData in data.items():
set_cookie_on_response(response, cookieData)

set_cookie_on_response(response, data, data.get("DS"))
set_cookie_on_response(response, data, data.get("DSR"))

return response


Expand Down