Skip to content

Conversation

aviadl
Copy link
Member

@aviadl aviadl commented Jun 8, 2022

  1. Implement SDK
  2. Implement simple sample app
  3. implement decorators, while doing that
    a. While doing that fixed all decorators, so they will get the client as a parameter, and we will not initiate it in the decorator file
    b. Removed hard coded project ids from code
    c. Removed public key const from code
  4. Added tests
  5. Renamed files of samples, so it will be clear what they are handling
  6. Added to gitignore file the .vscode dir

1. Implement SDK
2. Implement simple sample app
3. implement decorators, while doing that
 1. While doing that fixed all decorators, so they will get the client as a parameter, and we will not initiate it in the decorator file
 2. Removed hard coded project ids from code
 3. Removed public key const from code
4. Added tests
5. Renamed files of samples, so it will be clear what they are handling
6. Added to gitignore file the .vscode dir
@aviadl aviadl requested a review from guyp-descope June 8, 2022 16:23
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Coverage

Coverage Report
FileStmtsMissCover
TOTAL2940100%

Tests Skipped Failures Errors Time
22 0 💤 0 ❌ 0 🔥 1.326s ⏱️

@aviadl aviadl merged commit ece7613 into main Jun 9, 2022
@aviadl aviadl deleted the magic-link-support branch June 9, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants