-
Notifications
You must be signed in to change notification settings - Fork 8
Restructure the jwt_response object #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is an example of the new jwt_response object:
@meirwah FYI (it should not have any effect on the integration tests) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
-
regarding
cookieData
, did we consider just putting the field as top level fields with same name as the response from server? (similar to go-sdk) -
lets also make sure we handle logout properly (see Aviads PR descope/go-sdk#113)
I think our logout logic is good now (we changed it with Aviad after he changed the go sdk), Am I wrong here? did you found something that is not good/aligned? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:+1
No description provided.