Skip to content

Conversation

guyp-descope
Copy link
Contributor

Also fixed copy-paste issue ("invalid public key" which is not true :) )

@guyp-descope guyp-descope requested a review from asafshen August 15, 2022 11:37
@github-actions
Copy link

github-actions bot commented Aug 15, 2022

Coverage

Coverage Report
FileStmtsMissCoverMissing
descope
   auth.py218498%55, 395, 425–426
TOTAL723499% 

Tests Skipped Failures Errors Time
63 0 💤 0 ❌ 0 🔥 2.372s ⏱️

Copy link
Member

@asafshen asafshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch with exceptions copy pasting 👍

I have few questions about the removal, just wanted to make sure we understand the impact

lmk what you think

Copy link
Member

@asafshen asafshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@guyp-descope guyp-descope merged commit 1d40771 into main Aug 16, 2022
@guyp-descope guyp-descope deleted the adjust-delivery-method-verification branch August 16, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants