Skip to content

fix the parameters to magiclink verify func #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 18, 2022
Merged

fix the parameters to magiclink verify func #43

merged 2 commits into from
Aug 18, 2022

Conversation

guyp-descope
Copy link
Contributor

No description provided.

@guyp-descope guyp-descope requested a review from asafshen August 18, 2022 06:44
@github-actions
Copy link

github-actions bot commented Aug 18, 2022 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
descope
   auth.py217498%54, 393, 423–424
   descope_client.py52198%111
TOTAL730599% 

Tests Skipped Failures Errors Time
63 0 💤 0 ❌ 0 🔥 2.505s ⏱️

asafshen
asafshen previously approved these changes Aug 18, 2022
View reviewed changes
Copy link
Member

@asafshen asafshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

I also checked that it works in the cross device example, we have, next PR lets fix the wording there as well (unless we delete those apps)

image

@guyp-descope guyp-descope merged commit b1bc683 into main Aug 18, 2022
@guyp-descope guyp-descope deleted the fix-magiclink-sample branch August 18, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asafshen asafshen asafshen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guyp-descope @asafshen