Skip to content

Conversation

aviadl
Copy link
Member

@aviadl aviadl commented Sep 1, 2022

Change name of webauthn update functions
fix all tests
related to https://github.com/descope/etc/issues/476

Change name of webauthn update functions
fix all tests
related to descope/etc#476
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Coverage

Coverage Report
FileStmtsMissCoverMissing
descope
   auth.py228498%55, 414, 444–445
   descope_client.py45198%110
TOTAL722599% 

Tests Skipped Failures Errors Time
65 0 💤 0 ❌ 0 🔥 2.938s ⏱️

@aviadl aviadl requested a review from itaihanski September 1, 2022 09:51
Copy link
Member

@asafshen asafshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

we should also change examples
(didn't look on node-sdk PR, but there as well)

@aviadl
Copy link
Member Author

aviadl commented Sep 1, 2022

The example above doesnt need to change - since it is the example app routes
I actually think it is better that the routes are different

@aviadl aviadl requested a review from asafshen September 1, 2022 11:31
@aviadl aviadl merged commit 71ba33c into main Sep 1, 2022
@aviadl aviadl deleted the api-endpoint-refactor branch September 1, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants