support for executing an external Git environment #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68
@smashwilson I'm not sure if this is the whole solution as you saw it, but here's what it looks like in the test suite:
There's still some other assumptions around portable Git baked into this that might break for other usages, depending on how Git is setup on the user's machine:
GIT_EXEC_PATH
- this is set at compile time, and maybe we shouldn't set this if it's already defined like we currently are. It's hard to know whether this should be set at runtime without invokinggit --exec-path
GIT_TEMPLATE_DIR
- this might fail if not set, I can't really remember exactly. It's related to initializing repositories.PREFIX
- defines where Git is currently installed, to override lookups to the default location of/usr/local
Maybe we need some more control here and better respect for existing environment variables, as I'd love to keep the defaults just working with the embedded Git environment.