-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add a utility for connecting devcluster to remote k8s clusters #9739
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9739 +/- ##
==========================================
- Coverage 54.05% 54.04% -0.01%
==========================================
Files 1260 1260
Lines 155545 155545
Branches 3503 3502 -1
==========================================
- Hits 84074 84068 -6
- Misses 71325 71331 +6
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
tested and it worked for me inlcuding the gateway proxying stuff
@@ -0,0 +1,366 @@ | |||
#!/usr/bin/env python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another thing that would be awesome is if we didn't need to configure it as much and it just "worked"
maybe could store the ssh key in google cloud so we could just download it without needing to set up the ssh key path.
maybe we could default the kubeconfig and other things to current context
i'm happy with this as if if you think this could be done as a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea. we chatted offline. I added defaults to all the config options but the ssh key and the proxy host.
thanks for the review
let the devc class run devc
address a hang in the proxy set up if a failure occured
with us picking up the default k8s config make sure the user is aware when/if we provision a new gateway.
Ticket
https://hpe-aiatscale.atlassian.net/browse/RM-239
Description
This document describes the remote dev tooling for connecting devcluster to a kubernetes
cluster running in the cloud.
Overview of how this works:
Test Plan
Checklist
docs/release-notes/
See Release Note for details.