Staging/ideaspace #1944
Staging/ideaspace #1944
Conversation
Retprojects/involvement
fix(Spacing between radio buttons)
Chad updated grammar and sentences
Chad updated grammar
fix(Debugging vote button when logged out)
Dbradham/grammar updates
Development/ideaspace
|
|
@dev-launchers/platform-enablement when you get a chance, we would appreciate your review here! |
fix(Comment out like button in comment feed)
| `; | ||
|
|
||
| export const Input = styled.input` | ||
| height: 24px; | ||
| width: 24px; | ||
| /* width: 24px; */ |
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
hard-coded pixel width was causing the radio 'circles' to be 'ovals' that were stretched out
| @@ -32,13 +32,13 @@ function SubmissionForm() { | |||
| ); | |||
|
|
|||
| const getDBInvolveLevel = (involveString) => { | |||
| if (involveString.includes('and also believe')) { | |||
| if (involveString.includes('to end')) { | |||
There was a problem hiding this comment.
This looks hacky. Can we change the backend to store this as an enum?
There was a problem hiding this comment.
@chungthuang We can, but seems out of scope for this frontend change. We would still need to map the values to an enum.
Do you have a solution in mind that avoids making a comparison like this to get a value to save to the database?
There was a problem hiding this comment.
@chungthuang just saw your other comment and updated this
| Idea Info | ||
| <hr noshade="false" style={{margin: "1rem auto 2rem"}}/> | ||
| </atoms.Typography> | ||
| const compareValuesToInitial = (values) => { |
There was a problem hiding this comment.
Can you give an example of what are we comparing?
There was a problem hiding this comment.
@chungthuang this is to check if any form values have been updated.
| /> | ||
| <atoms.Radio | ||
| onChange={(e, label) => | ||
| setFieldValue('involveLevel', label) |
There was a problem hiding this comment.
Can we set field to "highly", so we don't need this conversion https://github.com/dev-launchers/dev-launchers-platform/pull/1944/files#r1744700300?
There was a problem hiding this comment.
@chungthuang yes thanks for the recommendation here, this is complete.
…Form fix(stop using comparison)
Development/ideaspace
Removed tags, sort recent ideas, sort time commitment, navigation routes, tool tip fix
Development/ideaspace
| @@ -139,12 +139,12 @@ function SingleCommentComponent(props) { | |||
| </div> | |||
| </SingleCommentContent> | |||
| <SingleCommentButtons style={{ display: 'flex' }}> | |||
| <LikeButton | |||
| {/* <LikeButton | |||
There was a problem hiding this comment.
Why are we commenting this out?
|
🎉 This PR is included in version 2.19.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.