Skip to content

Commit 30b9fc4

Browse files
ranchodeluxeranchodeluxe
andauthored
docs (#129)
Co-authored-by: ranchodeluxe <greg.corradini@gmail.com>
1 parent a837f97 commit 30b9fc4

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

.github/workflows/pre-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ jobs:
147147
git fetch origin
148148
git checkout ${{ github.head_ref }}
149149
git add -A
150-
git commit -m "release version to ${{ env.new_version }}"
150+
git commit -m "release version to v${{ env.new_version }}"
151151
# only tag main branch in manual release
152152
# git tag "v${{ env.new_version }}"
153153
git push origin ${{ github.head_ref }}

docs/release.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,26 +5,25 @@ title that decides if the chart's version bumps will be major, minor or patch ac
55
All they need to do is prefix `major: `, `minor: ` or `patch: ` to the PR title
66

77

8-
2. All PRs merged against the base `main` will kick off a "pre-release" workflow that does the following:
8+
2. All PRs opened, synchronized or reopened against `main` will kick off a "pre-release" workflow that does the following:
99

1010
1. detect if there are changes in the `helm-chart/` directory (if no changes are detected the "pre-release.yaml" workflow exits gracefully)
1111

1212
2. sniff the PR title to determine major, minor or patch bumps
1313

1414
3. increment the helm chart's `version` and `appVersion` accordingly
1515

16-
4. create a new PR with these changes with a title called
17-
`'release ${{ env.new_version }} for ${{ github.ref }}@${{ github.sha }}'` and body listing the new chart version
16+
4. add a commit to the open PR with the `Chart.yaml` bumps and a commit titled: `'release version to v<version-increment>`
1817

1918

20-
3. The releaser should find this PR, review and merge accordingly
19+
3. The releaser should review this PR and make sure everything (include the `Chart.yaml` bumps seem correct). Then merge the PR
2120

2221

23-
4. Then the releaser should go to the Github release UI/UX and kick off a new release by doing the following:
22+
3. Then the releaser should go to the Github release UI/UX and kick off a new release by doing the following:
2423

2524
1. click "Draft New Release"
2625

27-
2. create a new tag for the branch `main` with the chart version listed in the previous PR's body and title
26+
2. create a new tag for the branch `main` with the chart version listed in the previous PR's commit message
2827

2928
3. click the "Generate release notes"
3029

0 commit comments

Comments
 (0)