feat: skip json middleware based on response data type #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or transformation - Added `expected_data_type` attribute to `JsonResponseMiddleware` to specify the type of JSON responses to transform. - Implemented logic to skip transformation for unexpected data types, with appropriate logging. - Introduced example middleware classes for handling string, list, and any JSON response types, demonstrating the new functionality. - Updated tests to validate behavior for various expected data types and transformation scenarios.
alukach
deleted the
feat/skip-json-middleware-based-on-response-data-type
branch
alukach
pushed a commit
that referenced
this pull request
Oct 14, 2025
🤖 I have created a release *beep* *boop* --- ## [0.10.0](v0.9.2...v0.10.0) (2025-10-14) ### Features * skip json middleware based on response data type ([#103](#103)) ([16b05c3](16b05c3)) * support customizing port when running as a module ([9a18c49](9a18c49)) ### Documentation * **config:** add admonitions for more details ([40444cf](40444cf)) * **config:** cleanup formatting ([8a82d3d](8a82d3d)) * update tips to describe non-upstream URL ([ebadd52](ebadd52)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: ds-release-bot[bot] <116609932+ds-release-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
Allow middleware to be written with an
expected_data_typeargument to determine if the JSON should be processed. This is useful in order to ignore API endpoints that don't return dictionaries (e.g. STAC FastAPI's bulk-insert which returns astr)