Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registry Viewer: Pass client property to server side calls #651

Closed
kim-tsao opened this issue Oct 20, 2021 · 2 comments · Fixed by devfile/registry-viewer#29 or devfile/registry-viewer#30
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure
Projects

Comments

@kim-tsao
Copy link
Contributor

kim-tsao commented Oct 20, 2021

Which area/kind this issue is related to?

/area registry

Issue Description

Since Woopra page events are not supported in our current set up, we can work around this by tracking the endpoint calls made from the registry viewer but in order to see the data, we will need the info to be passed into the header so things like userid/anonymousId, country, client, devfile/url, etc can be collected. Setting the anonymousId and client properties are under development so there is a dependency to this issue: #678

  • Add an HTML header on the registry viewer API calls to identify the registry viewer so we can filter the events out.
@kim-tsao kim-tsao added the area/registry Devfile registry for stacks and infrastructure label Oct 20, 2021
@kim-tsao kim-tsao added this to Under consideration in Sprint 208 via automation Oct 20, 2021
@johnmcollier johnmcollier removed this from Under consideration in Sprint 208 Oct 21, 2021
@johnmcollier johnmcollier added this to Under consideration in Sprint 209 via automation Oct 21, 2021
@johnmcollier johnmcollier removed this from Under consideration in Sprint 209 Nov 16, 2021
@johnmcollier johnmcollier added this to Under consideration in Sprint 210 via automation Nov 16, 2021
@kim-tsao kim-tsao changed the title Pass in the Accept-Language header when issuing API calls from the registry viewer Pass telemetry data to server side calls Nov 17, 2021
@kim-tsao
Copy link
Contributor Author

Once this change is made, we can remove the page events from the viewer

@kim-tsao kim-tsao changed the title Pass telemetry data to server side calls Registry Viewer: Pass telemetry data to server side calls Nov 17, 2021
@schultzp2020 schultzp2020 moved this from Under consideration to In progress in Sprint 210 Nov 19, 2021
@schultzp2020 schultzp2020 moved this from In progress to Review in progress in Sprint 210 Nov 19, 2021
@kim-tsao
Copy link
Contributor Author

Since Page events were converted to track events, we no longer need to pass most of the info from the client to server so the requirements have changed. Can we just pass in the client property? That way, we can distinguish which API calls are from the registry viewer and suppress telemetry collection on this since these will be dup calls

@kim-tsao kim-tsao changed the title Registry Viewer: Pass telemetry data to server side calls Registry Viewer: Pass client property to server side calls Nov 23, 2021
Sprint 210 automation moved this from Review in progress to Done Nov 30, 2021
@schultzp2020 schultzp2020 moved this from Done to In progress in Sprint 210 Nov 30, 2021
@schultzp2020 schultzp2020 reopened this Nov 30, 2021
Sprint 210 automation moved this from In progress to Done Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure
Projects
No open projects
2 participants