Skip to content

Conversation

JPinkney
Copy link
Contributor

Signed-off-by: Josh Pinkney joshpinkney@gmail.com

What does this PR do?:

Which issue(s) this PR fixes:

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

Signed-off-by: Josh Pinkney <joshpinkney@gmail.com>
@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JPinkney

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JPinkney
Copy link
Contributor Author

Superseded by #551

@JPinkney JPinkney closed this Jul 22, 2021
@JPinkney JPinkney deleted the devfile-types branch July 22, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant