generate typescript model basing on schemas instead of CRDs #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
force-pushed
the
typescriptBasedOnSchemas
branch
from
b9f5cb8 to
9dc6099
Compare
JPinkney
reviewed
Jul 21, 2021
| @@ -1,2 +0,0 @@ | |||
| requests==2.24.0 | |||
There was a problem hiding this comment.
Since we no longer have dependencies we can probably remove this file along with https://github.com/devfile/api/blob/main/.github/workflows/release-typescript-models.yaml#L30
sleshchenko
force-pushed
the
typescriptBasedOnSchemas
branch
from
a3dbe0c to
9448ff1
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JPinkney, sleshchenko The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
generate typescript model basing on schemas instead of CRDs
Which issue(s) this PR fixes:
it should fix #494 and #493
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer:
Metadata type appears:
Devfile type appears: