Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set v1alpha1 DevWorkspaces as served: false #635

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

amisevsk
Copy link
Contributor

@amisevsk amisevsk commented Oct 6, 2021

What does this PR do?:

Set served:false for v1alpha1 DevWorkspaces and DevWorkspaceTemplates.

Which issue(s) this PR fixes:

Requirement for #634

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

This is a prerequisite to removing the v1alpha1 version from
DevWorkspaces

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Typescript generation fails https://github.com/devfile/api/runs/3816931403
I've rerun hoping it will pass but some work may be needed there, feel free to ask @JPinkney help

P.S.

W: The repository 'deb.nodesource.com/node_14.x stretch Release' does not have a Release file.

probably that's temporary unavailability of package repo

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, JPinkney, sleshchenko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JPinkney
Copy link
Contributor

JPinkney commented Oct 6, 2021

It looks like the CI is failing because of: nodesource/distributions#1266. Not much we can do on our side until the kubernetes client gen updates their Dockerfile. I'll open a PR there later today that will hopefully fix the issue

@openshift-ci
Copy link

openshift-ci bot commented Oct 6, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Oct 6, 2021
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants