Set served: true for v1alpha1 DevWorkspaces and DevWorkspaceTemplates #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l0rd
approved these changes
Mar 17, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amisevsk, l0rd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
serve-v1alpha1
branch
from
166b18e
to
a7fde49
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Fixes a minor oversight in #738, which accidentally left v1alpha1 DevWorkspaces and DevWorkspaceTemplates as
served: false. For the same reasons that the v1alpha1 API version needed to be returned, it also needs to be served -- otherwise OpenShift Console will fail to create Web Terminals.Which issue(s) this PR fixes:
Related: #721
PR acceptance criteria:
How to test changes / Special notes to the reviewer:
After changes, it should be possible to do e.g.
oc get devworkspaces.v1alpha1.workspace.devfile.iowith the updated CRDs applied to the cluster.