Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pull in validation update #170

Merged
merged 4 commits into from
Apr 14, 2023
Merged

pull in validation update #170

merged 4 commits into from
Apr 14, 2023

Conversation

yangcao77
Copy link
Collaborator

@yangcao77 yangcao77 commented Apr 13, 2023

What does this PR do?:

Pulls in latest devfile/api module, which contains the endpoint validation update.

Which issue(s) this PR fixes:

fixes devfile/api#1049

PR acceptance criteria:

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer:

Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Stephanie <yangcao@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Apr 13, 2023
Signed-off-by: Stephanie <yangcao@redhat.com>
@yangcao77 yangcao77 requested a review from kim-tsao April 13, 2023 15:25
@@ -1,5 +1,5 @@

Copyright 2022 Red Hat, Inc.
Copyright 2022-2023 Red Hat, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we leave it as the year 2023? This is supposed to be for new files that we create. Existing files missing the headers should have the year they were created (we'd have to go back and fix them)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Signed-off-by: Stephanie <yangcao@redhat.com>
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c1b23d2) 61.28% compared to head (70a8a32) 61.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   61.28%   61.28%           
=======================================
  Files          37       37           
  Lines        4373     4373           
=======================================
  Hits         2680     2680           
  Misses       1531     1531           
  Partials      162      162           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yangcao77 yangcao77 requested a review from kim-tsao April 14, 2023 04:44
@openshift-ci openshift-ci bot added the lgtm label Apr 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, yangcao77

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants