feat: allow export of profile for cloud mode #2960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the export functionality and makes the export button universally available. The changes correct the parameter being passed to exportProfile() and remove the cloud-mode restriction on the export button.
- Fixed parameter mismatch in
export()method by usingprofile.profileNameinstead ofname - Removed conditional
cloudModecheck that was hiding the export button in cloud environments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/app/profiles/profiles.component.ts | Corrects parameter usage in exportProfile() calls to use profile.profileName instead of undefined name variable |
| src/app/profiles/profiles.component.html | Removes @if (!cloudMode) conditional wrapper around the export button to make it available in all modes |
graikhel-intel
approved these changes
Nov 3, 2025
auto-merge was automatically disabled
November 3, 2025 22:01
Rebase failed
RosieAMT
pushed a commit
that referenced
this pull request
Nov 5, 2025
# [3.49.0](v3.48.0...v3.49.0) (2025-11-05) ### Features * allow export of profile for cloud mode ([#2960](#2960)) ([008e60c](008e60c))
|
🎉 This PR is included in version 3.49.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )