-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove SponsorLink since it breaks MacOS restore #1375
Conversation
Hello, should we expect that SponsorLink is back after MacOS restore is fixed? |
It does not contain removal of the project, just the reference in the main csproj. So probably it will be back |
"This is fine" - so you are only removing it since it breaks MacOS?... Really? How can you ignore all the voices screaming about this being a horrible change. Not only horrible change, but literally killing moq all together for them. For example, I would need to throw Moq out of my Unittests at my company, since it violates a lot of security practices and GDPR.
|
Omg, looks, like the reaction on the problem is going to be even more hilarious than the problem itself. |
Is MacOS restore only one reason? |
Tell the community you've learned nothing from this without telling them. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Moq](https://togithub.com/moq/moq) | nuget | patch | `4.20.1` -> `4.20.2` | --- ### Release Notes <details> <summary>moq/moq (Moq)</summary> ### [`v4.20.2`](https://togithub.com/moq/moq/releases/tag/v4.20.2) <!-- Release notes generated using configuration in .github/release.yml at main --> ##### What's Changed ##### 🐛 Fixed bugs - Remove SponsorLink since it breaks MacOS restore by [@​kzu](https://togithub.com/kzu) in [https://github.com/moq/moq/pull/1375](https://togithub.com/moq/moq/pull/1375) **Full Changelog**: moq/moq.spikes@v4.20.1...v4.20.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
what has the community done to support @kzu ? |
There's an issue for folks to join the conversation on this moving forward: https://github.com/moq/moq/issues/1374 |
Told him, in many different ways, just how bad an idea this was. |
The community (at least those that were able) signed up as sponsors of the project. Let's keep the discussion in proper perspective. It looks like the goal of adding Sponsorlink to Moq was to give something back to the sponsors and reap additional rewards to the Moq project. I might be wrong, but Sponsorlink looks like an effort to bring advertising to OSS via an affiliate program. Personally, I don't want ads in my builds. I turned that flag off in npm when ads starting showing up during |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Moq](https://togithub.com/moq/moq) | nuget | patch | `4.20.2` -> `4.20.69` | --- ### Release Notes <details> <summary>moq/moq (Moq)</summary> ### [`v4.20.69`](https://togithub.com/moq/moq/releases/tag/v4.20.69) Let's make it more memorable when Moq became "safe" again. #### What's Changed - Removed SponsorLink [https://github.com/moq/moq/pull/1375](https://togithub.com/moq/moq/pull/1375) - Remove AWS sponsorship from readme by [@​kzu](https://togithub.com/kzu) in [https://github.com/moq/moq/pull/1383](https://togithub.com/moq/moq/pull/1383) - Add everyone how now DOES sponsor 🫶 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Abstractions). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi40MC4zIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [Moq](https://togithub.com/moq/moq) | nuget | patch | `4.20.1` -> `4.20.69` | --- ### Release Notes <details> <summary>moq/moq (Moq)</summary> ### [`v4.20.69`](https://togithub.com/moq/moq/releases/tag/v4.20.69) Let's make it more memorable when Moq became "safe" again. #### What's Changed - Removed SponsorLink [https://github.com/moq/moq/pull/1375](https://togithub.com/moq/moq/pull/1375) - Remove AWS sponsorship from readme by [@​kzu](https://togithub.com/kzu) in [https://github.com/moq/moq/pull/1383](https://togithub.com/moq/moq/pull/1383) - Add everyone how now DOES sponsor 🫶 ### [`v4.20.2`](https://togithub.com/moq/moq/releases/tag/v4.20.2) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed ##### 🐛 Fixed bugs - Remove SponsorLink since it breaks MacOS restore by [@​kzu](https://togithub.com/kzu) in [https://github.com/moq/moq/pull/1375](https://togithub.com/moq/moq/pull/1375) > NOTE: in addition, there were potential privacy issues raised with regards to the SHA256 hashing of > user' email to check for sponsorship, so it won't be coming back until that's properly addressed **Full Changelog**: moq/moq.spikes@v4.20.1...v4.20.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Testably/Testably.Architecture.Rules). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuNDAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
NOTE: there are also concerns that the SHA256 of the email that's used to check for sponsorships may be an issue with GDPR. So that part at least, isn't coming back, at all.
On the underlying issue of SponsorLink itself, and OSS sustainability, please join the conversation at https://github.com/moq/moq/issues/1374
Fixes #1371