Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom evironment variables from devon.properties not available in IDE (e.g. Eclipse) #493

Closed
fdcg opened this issue Nov 4, 2020 · 3 comments · Fixed by #501
Closed
Labels
bug Something isn't working eclipse related to Eclipse IDE scripts related to shell scripts (bash and CMD)

Comments

@fdcg
Copy link
Contributor

fdcg commented Nov 4, 2020

Expected behavior

As a developer, I want to use correct settings in Eclipse IDE.

Actual behavior

Starting Eclipse with the command 'devon eclipse' in a workspace folder or staring with the generated start script do not set devon environment variables.

Steps to reproduce (bug) / Use Case of feature request (enhancement)

  1. Use devon environment variables in the maven settings.xml e.g. for the url of a repository server.
  2. Start Eclipse with the generated start script
  3. In Eclipse import a new maven project with File -> Import -> Excisting Maven Project
  4. The imported project has no maven dependencies in the build path because the url variable in the maven settings can not be found.

Related/Dependent Issues

Comments/Hints:

Affected version:

  • OS: Windows 10
  • devon IDE: 2020.08.001
@fdcg fdcg added the bug Something isn't working label Nov 4, 2020
@hohwille
Copy link
Member

I can not reproduce this bug and it is working for many others including me.
Hence, you need to provide additional details about your environment.
So your m2e (maven eclipse plugin) can not resolve dependencies. This can have arbitrary reasons (no internet, settings.xml broken, etc.). You would need to provide the error/exception details.
Does maven resolve the dependencies on the commandline (devon, mvn clean install)?

@hohwille hohwille added waiting-for-feedback we have asked a question and the issue is pending until an answer is provided and removed bug Something isn't working labels Dec 4, 2020
@hohwille
Copy link
Member

@fdcg could you comment on this issue? Otherwise we will have to close it as invalid since we can not proceed without further details.

@hohwille hohwille changed the title Starting Eclipse IDE do not set devon evironment variables Starting Eclipse IDE does not set devon evironment variables Dec 14, 2020
@hohwille hohwille added bug Something isn't working eclipse related to Eclipse IDE scripts related to shell scripts (bash and CMD) windows specific for Microsoft Windows OS and removed waiting-for-feedback we have asked a question and the issue is pending until an answer is provided labels Dec 14, 2020
@hohwille
Copy link
Member

hohwille commented Dec 14, 2020

@fdcg and I analyzed this problem together:

  • it only happens for more specific variables
  • the problem is that devon eclipse will set the variables in bash and not in cmd. When it then calls eclipse or any other process from that bash only exported variables apear to be set in that process (here eclipse).
  • therefore a quick workaround is to add "export " before these variables in you devon.properties file.
  • however, we should find a better solution and IMHO launching devon eclipse (or calling any other IDE via devon) should make all variables from devon.properties visible.
  • to avoid exporting all variables in the users shell what conflicts with reduce exposing of devon-ide scripts' variables to environment #5, we may simply only export whenever we call a devonfw subcommand.

@hohwille hohwille added this to the release:2020.12.002 milestone Dec 14, 2020
@hohwille hohwille removed the windows specific for Microsoft Windows OS label Dec 14, 2020
@hohwille hohwille changed the title Starting Eclipse IDE does not set devon evironment variables custom evironment variables from devon.properties not available in IDE (e.g. Eclipse) Dec 14, 2020
@hohwille hohwille linked a pull request Dec 14, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working eclipse related to Eclipse IDE scripts related to shell scripts (bash and CMD)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants