-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add FNV1a hash function #1760
base: master
Are you sure you want to change the base?
Conversation
Surprising how few tests fail with this! |
nice :). |
Results from running this script as a benchmark.
The thing to look at are the last three columns which measure how long how it takes to load kmers, lookup a kmer that isn't present and kmers which are present. Observations: the benchmark isn't very useful because it is pretty noisy and I'd conclude that FNV1a is no faster than murmurhash. I find that at least somewhat surprising. |
Question for all y'all - are we benchmarking with different *numbers* of hash
tables? I'm wondering if the prime number modulus is causing any issues.
I am still stuck on the question of (a) whether things could be faster,
(b) if so, how easy it would be to speed things up. Right now we seem
to be stuck in the never never land of "it's hard to identify any one
factor that is slowing things down."
|
Codecov Report
@@ Coverage Diff @@
## master #1760 +/- ##
=========================================
+ Coverage 0.05% 0.06% +<.01%
=========================================
Files 87 78 -9
Lines 11441 9807 -1634
Branches 3072 2459 -613
=========================================
Hits 6 6
+ Misses 11435 9801 -1634
Continue to review full report at Codecov.
|
Fixes #1757
Test driving the FNV hash. Benchmarks to do:
make test
Did it pass the tests?make clean diff-cover
If it introduces new functionality inscripts/
is it tested?make format diff_pylint_report cppcheck doc pydocstyle
Is it wellformatted?
additions are allowed without a major version increment. Changing file
formats also requires a major version number increment.
documented in
CHANGELOG.md
? See keepachangelogfor more details.
changes were made?
tested for streaming IO?)