Skip to content

Use is_not_zero in simplifier #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Conversation

tautschnig
Copy link
Collaborator

Avoid duplicating its implementation to reduce code size and improve
maintainability.

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Avoid duplicating its implementation to reduce code size and improve
maintainability.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: b98e818).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87949806

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_not_zero does do the right thing with floats, right?

@tautschnig
Copy link
Collaborator Author

is_not_zero does do the right thing with floats, right?

It does have dedicated handling for that case, which amounts to the same that the code removed here was doing. But then I need to to defer back to you to determine whether that is the right thing...

@martin-cs
Copy link
Collaborator

martin-cs commented Oct 15, 2018 via email

@kroening kroening merged commit fe7e385 into diffblue:develop Oct 15, 2018
@tautschnig tautschnig deleted the use-is_not_zero branch October 15, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants