Skip to content

Conversation

tautschnig
Copy link
Collaborator

We are not going to patch all the issues Visual Studio warns about in those code
bases.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We are not going to patch all the issues Visual Studio warns about in those code
bases.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 291343b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/98380294

Copy link
Contributor

@thk123 thk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know if there is something specific you wish me to comment on here - change looks fine to my untrained eye 🙂

@tautschnig tautschnig merged commit 68bc98d into diffblue:develop Jan 24, 2019
@tautschnig tautschnig deleted the vs-minisat branch January 24, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants