Skip to content

Conversation

kroening
Copy link
Collaborator

@kroening kroening commented Feb 5, 2019

The conversion has still assumed that bitvector contants are represented in
binary. This now uses the integer2bvrep interface.

Fixes #4066.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: dea63c9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99743896

kroening and others added 3 commits February 5, 2019 11:12
The conversion has still assumed that bitvector contants are represented in
binary. This now uses the integer2bvrep interface.
Adds support for comparison operations and unary minus.
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at, for example, cbmc/Float24 the code handling floating-point constants still appears to be very much broken, but at least it isn't obvious anymore...

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: a73ac9d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/99764225

@tautschnig tautschnig merged commit 13644d9 into develop Feb 5, 2019
@tautschnig tautschnig deleted the fix-smt2-binary branch February 5, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants