Skip to content

instructiont::apply #4267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 5, 2019
Merged

instructiont::apply #4267

merged 2 commits into from
Mar 5, 2019

Conversation

kroening
Copy link
Member

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
Copy link
Collaborator

It seems that the property numbering has changed, or some other undesired side effect that's now making the mcdc tests fail.

Daniel Kroening added 2 commits February 25, 2019 09:24
This avoids direct accesses to the members of instructiont.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫
This PR failed Diffblue compatibility checks (cbmc commit: 11e0f6c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102133985
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.

@owen-mc-diffblue
Copy link
Contributor

@kroening Your last force-push reverted your changes to src/goto-instrument/cover_util.cpp. Was that deliberate?

@kroening
Copy link
Member Author

@owen-jones-diffblue Yes, that breaks a test relating to MC/DC, and needs a closer look.

@kroening
Copy link
Member Author

I believe it's related to the ordering, as suspected by @tautschnig

@tautschnig tautschnig merged commit a151280 into develop Mar 5, 2019
@tautschnig tautschnig deleted the instructiont-apply branch March 5, 2019 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants