Clean up/enable StringBuilder.append tests #4862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String s = sb.toString(); | ||
| assert(s.equals("fg")); | ||
| } | ||
| public static void nondet(String stringArg, int intArg) |
There was a problem hiding this comment.
I don't see where intArg is used
| String s = sb.toString(); | ||
| assert(s.equals("fg")); | ||
| } | ||
| public static void nondet(String stringArg, int intArg) |
There was a problem hiding this comment.
⛏️ the name suggest there should also be a det test
There was a problem hiding this comment.
The tests for deterministic inputs are in the StringBuilderAppend[01] folders.
romainbrenguier
approved these changes
Jul 2, 2019
allredj
force-pushed
the
clean-up/enable-string-test
branch
from
c8ec34b to
62ceb1b
Compare
peterschrammel
approved these changes
Jul 2, 2019
| --function test.nondet --max-nondet-string-length 1000 --cp `../../../../scripts/format_classpath.sh . ../../../lib/java-models-library/target/core-models.jar` --property "java::test.nondet:(Ljava/lang/String;)V.assertion.1" | ||
| ^EXIT=10$ | ||
| ^SIGNAL=0$ | ||
| \[.*assertion\.1\] .* line 9 .* FAILURE |
There was a problem hiding this comment.
What about the other two assertions?
There was a problem hiding this comment.
I'm testing per-property, so the other assertions are checked in the two other desc files. Is that what you mean?
allredj
commented
Jul 2, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 62ceb1b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/117650646
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some StringBuilder tests were marked as FUTURE and caused by https://github.com/diffblue/test-gen/issues/434.
This seems now fixed, so I moved the tests to the main StringBuilder.append tests and enabled them, but I added a
--max-nondet-string-length 1000option. Not sure whether these tests should always pass without the option.@romainbrenguier do you think we can remove it (the tests don't fail locally without the option, but I'm worried they might at a later time)?