Skip to content

Conversation

antlechner
Copy link
Contributor

@antlechner antlechner commented Jul 2, 2019

In the tests for the --static-values option, we previously stored the value for an inherited static field twice, when it fact it is only needed in its declaring class.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

In the tests for static-values, we previously stored the value for an
inherited static field twice, when it fact it is only needed in its
declaring class.
Copy link

@majakusber majakusber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't quite understand the structure of these tests, only after some offline discussion. Consider adding a note to the readme file about the script in the cprover folder being just a simplified version of the actual, internal script.

"@type":"java.lang.Long",
"value":"9223372036854775807"
},
"inheritedStatic":{

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Is this how it works in the actual script too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be. 🙂
The "actual script" comments might be confusing for some people. I'll think about how to resolve this and will try to add some more info in a follow-up PR.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 057e4da).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/117691838

@jeannielynnmoulton jeannielynnmoulton removed their request for review July 3, 2019 17:04
@antlechner antlechner merged commit c7d2ef2 into diffblue:develop Jul 4, 2019
@antlechner antlechner deleted the antonia/no-inherited-in-json branch July 4, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants