Skip to content

Java frontend: support default methods #5352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2020

Conversation

smowton
Copy link
Contributor

@smowton smowton commented May 21, 2020

This fills in another missing JBMC feature: support inheriting default methods from interfaces that define them.

smowton added 3 commits May 21, 2020 12:07
This takes inheritance from interface default methods into account.
All areas of the codebase that resolve method implementations can now inherit a default
method when neither a class nor any of its parents provide a definition.
@smowton smowton force-pushed the smowton/feature/default-methods branch from 57a5826 to 1231e22 Compare May 21, 2020 11:07
@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #5352 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5352   +/-   ##
========================================
  Coverage    68.16%   68.16%           
========================================
  Files         1170     1170           
  Lines        96441    96450    +9     
========================================
+ Hits         65735    65743    +8     
- Misses       30706    30707    +1     
Flag Coverage Δ
#cproversmt2 42.47% <ø> (ø)
#regression 65.36% <100.00%> (-0.01%) ⬇️
#unit 31.77% <87.50%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
src/goto-programs/resolve_inherited_component.h 100.00% <ø> (ø)
jbmc/src/java_bytecode/ci_lazy_methods.cpp 100.00% <100.00%> (ø)
...src/java_bytecode/java_bytecode_convert_method.cpp 97.47% <100.00%> (ø)
src/goto-programs/remove_virtual_functions.cpp 94.38% <100.00%> (-0.06%) ⬇️
src/goto-programs/resolve_inherited_component.cpp 100.00% <100.00%> (ø)
src/util/string_utils.cpp 90.32% <0.00%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c608235...1231e22. Read the comment docs.

@smowton smowton merged commit a1f60ea into diffblue:develop May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants