Preserve lambda handles declared on string types #5355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
cesaro,
cristina-david,
peterschrammel,
pkesseli and
thk123
as code owners
peterschrammel
approved these changes
May 22, 2020
smowton
force-pushed
the
smowton/feature/string-type-lambdas
branch
from
864344e to
7dbae42
Compare
smowton
requested review from
chrisr-diffblue,
kroening,
romainbrenguier and
tautschnig
as code owners
smowton
force-pushed
the
smowton/feature/string-type-lambdas
branch
2 times, most recently
from
8b31fa3 to
df9b46b
Compare
Previously the lambda handles, methods and similar were removed when all we need for the string solver is to ensure the type has a <length, data> member pair in the manner of an array type.
We expect that StringBuilder and StringBuffer should derive from AbstractStringBuilder, and that String and CharSequence should derive directly from Object.
The complaint, that parts of optionalt may be used uninitialised, is unfounded, but there was no need for optional<reference_wrapper<...>> in the first place since that's just an elaborate alias for a pointer.
smowton
force-pushed
the
smowton/feature/string-type-lambdas
branch
from
df9b46b to
f022757
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5355 +/- ##
========================================
Coverage 68.16% 68.16%
========================================
Files 1170 1170
Lines 96450 96455 +5
========================================
+ Hits 65743 65748 +5
Misses 30707 30707
Continue to review full report at Codecov.
|
This was referenced Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the lambda handles, methods and similar were removed when all we need for the string
solver is to ensure the type has a <length, data> member pair in the manner of an array type.