Skip to content

Conversation

markrtuttle
Copy link
Collaborator

This pull requests add DgbHelp.lib to the list of libraries for util.lib to link against. Methods from the Visual Studio library DbgHelp like SymInitialize were added to print_backtrace in src/util/invariant.cpp to produce stack traces on windows.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #5387 into develop will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5387      +/-   ##
===========================================
- Coverage    68.19%   68.18%   -0.01%     
===========================================
  Files         1176     1173       -3     
  Lines        97527    97494      -33     
===========================================
- Hits         66510    66478      -32     
+ Misses       31017    31016       -1     
Flag Coverage Δ
#cproversmt2 42.45% <ø> (-0.29%) ⬇️
#regression 65.36% <ø> (-0.02%) ⬇️
#unit 32.21% <ø> (-0.04%) ⬇️
Impacted Files Coverage Δ
src/analyses/dependence_graph.h 77.77% <0.00%> (-6.67%) ⬇️
src/util/symbol_table_base.cpp 65.00% <0.00%> (-5.84%) ⬇️
...c/goto-harness/function_call_harness_generator.cpp 80.23% <0.00%> (-1.16%) ⬇️
src/goto-programs/json_goto_trace.h 90.00% <0.00%> (-0.91%) ⬇️
src/goto-harness/goto_harness_parse_options.cpp 77.77% <0.00%> (-0.71%) ⬇️
src/analyses/dependence_graph.cpp 90.38% <0.00%> (-0.27%) ⬇️
src/ansi-c/ansi_c_internal_additions.cpp 94.20% <0.00%> (-0.17%) ⬇️
src/util/config.cpp 56.66% <0.00%> (-0.16%) ⬇️
src/goto-programs/xml_goto_trace.cpp 98.26% <0.00%> (-0.03%) ⬇️
jbmc/src/java_bytecode/java_types.cpp 96.74% <0.00%> (-0.01%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a49e636...7bec868. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. There should be at least one regression test that purposely generates an assertion failure and thus a backtrace. If this could be made to work on Windows as well then we could check fo the problems caused by the lack of this library.

@markrtuttle
Copy link
Collaborator Author

@martin-cs The problem is that cbmc fails to build with cmake in the visual studio command shell without this change. This was not caught, I suspect, because CI has no cmake within the visual studio command shell. The windows cmake codebuild job appears to be running under powershell, based on the syntax of the shell commands. It would be reasonable to add another build to CI, but I don't know what regression test would make sense.

@martin-cs
Copy link
Collaborator

Thanks for the clarrification @markrtuttle

@markrtuttle markrtuttle force-pushed the cmake-windows-util-lib-link branch from c039521 to 7bec868 Compare July 6, 2020 15:25
@markrtuttle markrtuttle merged commit d453933 into diffblue:develop Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants