Skip to content

Remove unnecessary deprecate.h includes #5567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

tautschnig
Copy link
Collaborator

The procedures or methods marked DEPRECATED have been removed already,
but the #include was unnecessarily left in place.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The procedures or methods marked `DEPRECATED` have been removed already,
but the #include was unnecessarily left in place.
@tautschnig tautschnig assigned tautschnig and unassigned kroening Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #5567 (437b081) into develop (ff1e81e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5567   +/-   ##
========================================
  Coverage    69.01%   69.01%           
========================================
  Files         1187     1187           
  Lines        98257    98257           
========================================
  Hits         67809    67809           
  Misses       30448    30448           
Flag Coverage Δ
cproversmt2 43.09% <ø> (+<0.01%) ⬆️
regression 66.21% <ø> (ø)
unit 32.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/string_utils.h 100.00% <ø> (ø)
src/util/type.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff1e81e...437b081. Read the comment docs.

@tautschnig tautschnig merged commit b719a2c into diffblue:develop Nov 12, 2020
@tautschnig tautschnig deleted the remove-deprecated-include branch November 12, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants