Remove {f,F}orall_goto_functions #5615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #5615 +/- ##
===========================================
- Coverage 69.71% 69.71% -0.01%
===========================================
Files 1242 1242
Lines 100889 100889
===========================================
- Hits 70338 70334 -4
- Misses 30551 30555 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hannes-steffenhagen-diffblue
approved these changes
Nov 19, 2020
|
Yes please. Though I think it’d probably be a bit too ambitious to do them all in one PR |
tautschnig
force-pushed
the
remove-forall-macros
branch
from
a98d64a to
7ba3cca
Compare
tautschnig
force-pushed
the
remove-forall-macros
branch
2 times, most recently
from
90bd35a to
4cb985c
Compare
tautschnig
changed the title
tautschnig
force-pushed
the
remove-forall-macros
branch
from
4cb985c to
11d2947
Compare
tautschnig
changed the title
tautschnig
requested review from
chrisr-diffblue,
kroening,
martin-cs,
peterschrammel,
romainbrenguier and
smowton
as code owners
martin-cs
approved these changes
Jan 31, 2021
| @@ -173,7 +173,7 @@ class flow_insensitive_analysis_baset | |||
| const goto_functionst &goto_functions); | |||
|
|
|||
| bool fixedpoint( | |||
| goto_functionst::function_mapt::const_iterator it, | |||
| const goto_functionst::function_mapt::value_type &gf_entry, | |||
There was a problem hiding this comment.
This feels like it might be better as a goto_programt?
| } | ||
|
|
||
| bool flow_insensitive_analysis_baset::fixedpoint( | ||
| const goto_functionst::function_mapt::const_iterator it, | ||
| const goto_functionst::function_mapt::value_type &gf_entry, |
src/goto-checker/symex_coverage.cpp
Outdated
| @@ -52,7 +52,7 @@ class goto_program_coverage_recordt : public coverage_recordt | |||
| public: | |||
| goto_program_coverage_recordt( | |||
| const namespacet &ns, | |||
| goto_functionst::function_mapt::const_iterator gf_it, | |||
| const goto_functionst::function_mapt::value_type &gf_entry, | |||
There was a problem hiding this comment.
Feels a little cumbersome. Isn't this a goto_functiont?
There was a problem hiding this comment.
These also require the name of the goto_functiont. What could be done is passing that information as two arguments? That would probably make for are clearer interface. Let me fix this.
peterschrammel
approved these changes
Jan 31, 2021
This was useful in the past, but with C++-11 we can use a ranged-for to avoid the iterator altogether (in all but the cases in goto-diff, where we now make the iterator explicit).
tautschnig
force-pushed
the
remove-forall-macros
branch
from
11d2947 to
e8e0193
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was useful in the past, but with C++-11 we can use a ranged-for to
avoid the iterator altogether (in all but the cases in goto-diff, where
we now make the iterator explicit).