Skip to content

Conversation

tautschnig
Copy link
Collaborator

Apple decided to deviate from aarch64 configurations used by other
Unix-like operating systems as documented at
https://developer.apple.com/documentation/xcode/writing_arm64_code_for_apple_platforms#//apple_ref/doc/uid/TP40013702-SW1.

Fixes: #5627

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Apple decided to deviate from aarch64 configurations used by other
Unix-like operating systems as documented at
https://developer.apple.com/documentation/xcode/writing_arm64_code_for_apple_platforms#//apple_ref/doc/uid/TP40013702-SW1.

Fixes: diffblue#5627
@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #5628 (4435150) into develop (4d14272) will decrease coverage by 37.08%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #5628       +/-   ##
============================================
- Coverage    69.36%   32.27%   -37.09%     
============================================
  Files         1241      983      -258     
  Lines       100561    83533    -17028     
============================================
- Hits         69752    26962    -42790     
- Misses       30809    56571    +25762     
Flag Coverage Δ
cproversmt2 ?
regression ?
unit 32.27% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/config.cpp 29.36% <33.33%> (-28.28%) ⬇️
src/cpp/cpp_id.h 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/cpp_scope.h 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/cpp_token.h 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/cpp_name.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/cpp_util.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/util/identifier.h 0.00% <0.00%> (-100.00%) ⬇️
src/xmllang/graphml.h 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/cpp_is_pod.cpp 0.00% <0.00%> (-100.00%) ⬇️
src/cpp/template_map.h 0.00% <0.00%> (-100.00%) ⬇️
... and 945 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d14272...4435150. Read the comment docs.

@tautschnig tautschnig merged commit 4a30b87 into diffblue:develop Nov 22, 2020
@tautschnig tautschnig deleted the macos-arm64 branch November 22, 2020 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running compiled cbmc on Darwin/ARM64 violates 2 invariants
2 participants