Skip to content

Conversation

tautschnig
Copy link
Collaborator

This was left commented out ever since introducing it in 5952f6a,
which is reasonable for it required bumping the goto-program version. We
have incremented the version since 2014, and thus it is safe to enable
this now.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #5681 (bb7c787) into develop (de7f873) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5681   +/-   ##
========================================
  Coverage    69.64%   69.64%           
========================================
  Files         1248     1248           
  Lines       100915   100915           
========================================
  Hits         70285    70285           
  Misses       30630    30630           
Flag Coverage Δ
cproversmt2 43.36% <0.00%> (ø)
regression 66.62% <100.00%> (ø)
unit 32.18% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/util/config.cpp 57.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de7f873...bb7c787. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK but ... for those developers who weren't paying attention 7 years ago... any chance we could have some context or maybe a test (unit or regression) that this actually effects?

@tautschnig tautschnig self-assigned this Jan 14, 2021
@tautschnig tautschnig changed the title Enable reading NULL_is_zero from symbol table Enable reading NULL_is_zero from symbol table [depends-on: #5780] Jan 25, 2021
This was left commented out ever since introducing it in 5952f6a,
which is reasonable for it required bumping the goto-program version. We
have incremented the version since 2014, and thus it is safe to enable
this now, as also confirmed by the regression test.
@tautschnig tautschnig changed the title Enable reading NULL_is_zero from symbol table [depends-on: #5780] Enable reading NULL_is_zero from symbol table Jan 26, 2021
@tautschnig tautschnig merged commit 26b655b into diffblue:develop Jan 26, 2021
@tautschnig tautschnig deleted the null-is-zero branch January 26, 2021 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants